[PATCH] D71092: [VFS] More consistent support for Windows

amccarth closed this revision. amccarth added a comment. This landed in da45bd232165eab5d6ec4f1f4f18db8644289142 It wasn't automatically closed because I misspelled "Differential Revision." CHANGES SINCE LAST ACTION https:

[PATCH] D71092: [VFS] More consistent support for Windows

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 ___ cfe-commits mailing list cfe-commit

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth updated this revision to Diff 242190. amccarth marked an inline comment as done. amccarth added a comment. Addressed rnk's comments: fixed path style detection bug, and used `StringRef::endswith`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.o

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth marked 3 inline comments as done. amccarth added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:-1113 + sys::path::Style style = sys::path::Style::posix; + if (sys::path::is_absolute(WorkingDir.get(), sys::path::Style::windows)) { +style =

[PATCH] D71092: [VFS] More consistent support for Windows

rnk added a comment. I was worried there would be more duplication. :) As far as rebuilding the wheel square goes, this seems totally reasonable. I had a question and a nit, though. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:-1113 + sys::path::Style style = sys::

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth added a comment. cc: +thakis, who expressed interest in seeing a fix for the text exempted on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 ___ cfe-commits mailing list cfe-commi

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth updated this revision to Diff 240240. amccarth retitled this revision from "[VFS] Use path canonicalization on all paths" to "[VFS] More consistent support for Windows". amccarth edited the summary of this revision. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://r