[PATCH] D71084: Set a source location for Objective-C accessor stubs

2019-12-05 Thread Adrian Prantl via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa1a9aa17b4db: Set a source location for Objective-C accessor stubs even when there is no… (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D71084: Set a source location for Objective-C accessor stubs

2019-12-05 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71084/new/ https://reviews.llvm.org/D71084 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D71084: Set a source location for Objective-C accessor stubs

2019-12-05 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. In D71084#1771501 , @vsk wrote: > Shall we add in the assert we discussed in CFG::FinishFunction, as an > additional test? Done over in https://reviews.llvm.org/D71042 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7108

[PATCH] D71084: Set a source location for Objective-C accessor stubs

2019-12-05 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. Shall we add in the assert we discussed in CFG::FinishFunction, as an additional test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71084/new/ https://reviews.llvm.org/D71084 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D71084: Set a source location for Objective-C accessor stubs

2019-12-05 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl created this revision. aprantl added a reviewer: vsk. aprantl added a project: debug-info. Set a source location for Objective-C accessor stubs even when there is no explicit synthesize statement. This fixes a regression introduced in https://reviews.llvm.org/D68108 that could l