This revision was automatically updated to reflect the committed changes.
Closed by commit rGbd0f271c9e55: [ARM][MVE] Add intrinsics for immediate
shifts. (reland) (authored by simon_tatham).
Changed prior to commit:
https://reviews.llvm.org/D71065?vs=233025&id=233287#toc
Repository:
rG LLVM
dmgreen accepted this revision.
dmgreen added a comment.
One of the advantages to smaller patches I guess :)
It's probably difficult to tell if this will cause problems again without
trying it and see if any of the buildbots complain. Lets give it a try and see.
Just keep an eye on them, we ann
simon_tatham added subscribers: rdhindsa, hokein, echristo.
simon_tatham added a comment.
@hokein , @rdhindsa , @echristo : you all pointed out test failures in the
previous version. Any problems I haven't spotted with this one?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
simon_tatham reopened this revision.
simon_tatham added a comment.
This revision is now accepted and ready to land.
Reopening to review a revised version of this patch. It was reverted yesterday
because of a test failure in release builds, which looks like the result of a
warning fix that moved
simon_tatham updated this revision to Diff 233025.
simon_tatham added a comment.
Changes from previous version:
- minor cleanup: removed check of `hasIntegerConstantValue` in
`IRBuilderResult::more_prerequisites`, which was causing the generated codegen
to perofrm a pointless call to `EmitScala
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd97b3e3e65cd: [ARM][MVE] Add intrinsics for immediate
shifts. (authored by simon_tatham).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71065/new/
https://r
MarkMurrayARM accepted this revision.
MarkMurrayARM added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71065/new/
https://reviews.llvm.org/D71065
_
simon_tatham created this revision.
simon_tatham added reviewers: dmgreen, miyuki, MarkMurrayARM, ostannard.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls.
Herald added projects: clang, LLVM.
This adds the family of `vshlq_n` and `vshrq_n` ACLE intrinsics, which
shi
