[PATCH] D71063: [clangd] New rendering structs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.h:25 /// plaintext upon requrest. -class FormattedString { +class RenderableString { public: Naming: not sure "string" is the right name - it doesn't represent the things her

[PATCH] D71063: [clangd] New rendering structs

merge_guards_bot added a comment. Build result: pass - 60512 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71063: [clangd] New rendering structs

merge_guards_bot added a comment. Build result: pass - 60511 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71063: [clangd] New rendering structs

kadircet updated this revision to Diff 232332. kadircet added a comment. - Move function definitions to source file, via define out-of-line :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71063/new/ https://reviews.llvm.org/D71063 Files: clang-

[PATCH] D71063: [clangd] New rendering structs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a comment. kadircet added a parent revision: D70911: [clangd] Switch Hover.All to struct

[PATCH] D71063: [clangd] New rendering structs

kadircet added a comment. Note that I am planning to add more tests, sending out for review to get some initial feedback on the design. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71063/new/ https://reviews.llvm.org/D71063 ___