[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun added a comment. This is the next one: https://reviews.llvm.org/D71224 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71041/new/ https://reviews.llvm.org/D71041 ___ cfe-commits mailing list cf

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun added a comment. Just a cross reference, some of the discussed changes are implemented here: https://reviews.llvm.org/D71152 Hopefully, more will follow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71041/new/ https://reviews.llvm.org/

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_c

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:301 +// So the value in some sense escaped our analysis. +zx_handle_close(sa); + } else xazax.hun wrote: > This is also nasty. Cf.: ```lang=c++ int *x = malloc(sizeof(int)); if

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_c

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_c

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_c

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_c

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_c

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) -

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked 7 inline comments as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:211 + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), &sb)) +return; This one and i

[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun created this revision. xazax.hun added reviewers: NoQ, dcoughlin, Szelethus, baloghadamsoftware, haowei. xazax.hun added a project: clang. Herald added subscribers: cfe-commits, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet. I was running the Fuc