[PATCH] D70981: [opencl] Fix address space deduction on array variables.

2019-12-04 Thread Michael Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfa9dd410a9a9: [opencl] Fix address space deduction on array variables. (authored by hliao). Changed prior to commit: https://reviews.llvm.org/D70981?vs=231970&id=232123#toc Repository: rG LLVM Github

[PATCH] D70981: [opencl] Fix address space deduction on array variables.

2019-12-04 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please address the comment in your final commit. Comment at: clang/lib/Sema/SemaDecl.cpp:6136 + if (!OrigTy.getQualifiers().hasAddressSpace() && Orig

[PATCH] D70981: [opencl] Fix address space deduction on array variables.

2019-12-03 Thread Michael Liao via Phabricator via cfe-commits
hliao created this revision. hliao added a reviewer: Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. - The deduced address space needs applying to its element type as well. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70981 Files: c