[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added a comment. In D70818#1860115 , @Szelethus wrote: > I dont think any of my comments were addressed -- could you follow up? I addressed two, added fixme for another one. Now I ex

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

Szelethus added a comment. I dont think any of my comments were addressed -- could you follow up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 ___ cfe-commit

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rGb198f16e1e1c: [Analyzer] Model STL Algoirthms to improve the iterator checkers (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D70818?vs=242607&id=242647#toc Reposit

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! Tests for the other value of the option are welcome (: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 __

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/STLAlgorithmModeling.cpp:138-139 + SVB.getConditionType()); +assert(Less.getAs() && + "Symbol co

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware updated this revision to Diff 242607. baloghadamsoftware added a comment. Updated: checker moved to alpha.cplusplus (until at least one of the iterator-related checkers gets out of alpha state or a new non-alpha container checker is created). Error-branch is protected by an op

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

Szelethus added a comment. Also, I really like this patch, its well documented, small and very well tested! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:644 Dependencies<[ContainerModeling]>, - Documentation, - Hidden; - -def InvalidatedIteratorChecker : Checker<"InvalidatedIterator">, - HelpText<"Check for use of invalidate

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

NoQ added a comment. Other than the packaging debate, i think this check looks good! Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:641 -} // end: "optin.cplusplus" - -let ParentPackage = CplusplusAlpha in { - -def ContainerModeling : Checker<"ContainerMo

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware updated this revision to Diff 241364. baloghadamsoftware added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td clang/lib/StaticAnalyzer/Che

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware added a comment. This patch supersedes both https://reviews.llvm.org/D32905 and https://reviews.llvm.org/D54149. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818 __

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity, mgorny. baloghadamsoftware added a parent re