t.p.northover closed this revision.
t.p.northover added a comment.
Thanks Ahmed, pushed:
To github.com:llvm/llvm-project.git
0a4daff6e26f..903e5c3028d6 master -> master
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70779/new/
https://reviews.llvm.org/D70779
_
ab added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64.td:587
+"Apple A10", [
+ProcAppleA7,
+FeatureCRC,
ab wrote:
> t.p.northover wrote:
>
ab accepted this revision.
ab added a comment.
(but either way, LGTM)
Comment at: llvm/lib/Target/AArch64/AArch64.td:587
+"Apple A10", [
+ProcAppleA7,
+FeatureCRC,
--
t.p.northover updated this revision to Diff 231872.
t.p.northover added a comment.
Stop inheriting CPU features because they aren't necessarily strictly monotonic.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70779/new/
https://reviews.llvm.org/D70779
Files:
clang/lib/Driver/ToolCha
t.p.northover marked an inline comment as done.
t.p.northover added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64.td:587
+"Apple A10", [
+ProcAppleA7,
+Featu
ab added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64.td:587
+"Apple A10", [
+ProcAppleA7,
+FeatureCRC,
I'm not sure we want to reuse the f
fhahn added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:143
MtuneLowerCase = llvm::sys::getHostCPUName();
- if (MtuneLowerCase == "cyclone") {
+ if (MtuneLowerCase == "cyclone" || MtuneLowerCase.find("apple") == 0) {
Features.push_back("+
kristof.beyls added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:143
MtuneLowerCase = llvm::sys::getHostCPUName();
- if (MtuneLowerCase == "cyclone") {
+ if (MtuneLowerCase == "cyclone" || MtuneLowerCase.find("apple") == 0) {
Features.push
t.p.northover marked an inline comment as done.
t.p.northover added a comment.
Thanks Florian. I'll wait as you suggest.
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:143
MtuneLowerCase = llvm::sys::getHostCPUName();
- if (MtuneLowerCase == "cyclone") {
+ if (
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM, but it might be good to wait with committing until next week, so people
in the US have a chance to take a look as well.
Comment at: clang/lib/Driver/ToolChains/Arch/AArc
kristof.beyls added a comment.
I agree the bare names could cause a lot of confusion, and that the naming
scheme proposed in this patch resolves that potential confusion.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70779/new/
https://reviews.llvm.org/D70779
___
t.p.northover updated this revision to Diff 231220.
t.p.northover added a comment.
Test updates after switching arm64_32 default CPU to apple-s4.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70779/new/
https://reviews.llvm.org/D70779
Files:
clang/lib/Driver/ToolChains/Arch/AArch64.c
t.p.northover created this revision.
t.p.northover added a reviewer: ab.
Herald added subscribers: hiraditya, kristof.beyls, mcrosier.
Herald added a project: LLVM.
t.p.northover updated this revision to Diff 231220.
t.p.northover added a comment.
Test updates after switching arm64_32 default CPU
13 matches
Mail list logo
