[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; jdoerfert wrote: > ABat

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > > jdoe

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; jdoerfert wrote: > ABat

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; ABataev wrote: > jdoerfert wrote: > > I would like to avoid the

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

merge_guards_bot added a comment. Build result: pass - 60340 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev marked 2 inline comments as done. ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; jdoerfert wrote: > I wo

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev updated this revision to Diff 231265. ABataev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70739/new/ https://reviews.llvm.org/D70739 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basi

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/test/OpenMP/nvptx_declare_variant_device_isa_codegen.cpp:48 + +#pragma omp declare variant(foo) match(device = {isa("nvptx64")}) +int bar() { return 1; } jdoerfert wrote: >

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

jdoerfert added a comment. Thanks for working on this! One nit and one concern below. Comment at: clang/include/clang/Sema/Sema.h:9320 using OMPCtxSelectorData = - OpenMPCtxSelectorData, ExprResult>; + OpenMPCtxSelectorData, ExprResult>; I would

[PATCH] D70739: [OPENMP50]Add device/isa context selector support.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added a subscriber: guansong. Herald added a project: clang. Added basic support for device/isa context selector. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70739 Files: clang/include/clang/Basic/