[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen added a comment. Can you commit it again for me? thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726 ___

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added inline comments. Comment at: clang/test/OpenMP/parallel_master_codegen.cpp:67 + +// CK2: define internal {{.*}}void [[OMP_OUTLINED]](i32* noalias %.global_tid., i32* noalias %.bound_tid.) +// CK2-NOT: __kmpc_global_thread_num Not the best i

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added inline comments. Comment at: clang/test/OpenMP/parallel_master_codegen.cpp:144 +// CK4: [[A_VAL:%.+]] = alloca i32 +// CK4: [[A_CASTED:%.+]] = alloca i{{32|64}} +// CK4: [[ZERO:%.+]] = load i32, i32* [[A_VAL]] I think it would be b

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen added a comment. I've found it: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/1042 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726 ___

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen added a comment. How to see the test result on Windows? I've no windows machine to test the compiler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726 ___

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev reopened this revision. ABataev added a comment. This revision is now accepted and ready to land. Need to fix tests on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726 _

[PATCH] D70726: [OpenMP50] Add parallel master construct

rnk added a comment. One of the new tests doesn't pass on Windows, so I reverted this in rG33f6d465d790ac5c9b949e6bc05127d356212079 . I made an attempt to fix the checks, but it wasn't trivial. Repository: rG LLVM Github M

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen added a comment. @ABataev, thanks for your time and patient for the review! Could you land this patch for me when you have free time? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726 ___

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:1875 + /// \param AssociatedStmt Statement, associated with the directive. + /// \param HasCancel true if current directive has inner cancel directive. + /// No such param. =

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added inline comments. Comment at: clang/test/OpenMP/parallel_master_codegen.cpp:1 +// expected-no-diagnostics +#ifndef HEADER A codegen test for `if`, `proc_bind` and `allocate` clauses? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/test/OpenMP/nesting_of_regions.cpp:3024 + { +#pragma omp master // OK, though second 'master' is redundant +{ ABataev wrote: > Is this allowed by the standard? I didn't se

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2933 +OMPPrivateScope PrivateScope(CGF); +bool Copyins = CGF.EmitOMPCopyinClause(S); +(void)CGF.EmitOMPFirstprivateClause(S, PrivateScope);

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:1879 + Create(const ASTContext &C, SourceLocation StartLoc, SourceLocation EndLoc, + ArrayRef Clauses, Stmt *AssociatedStmt, bool HasCancel); + `HasCancel` param? =

[PATCH] D70726: [OpenMP50] Add parallel master construct

ABataev added a comment. Missing check for prohibited nesting of the barrier and worksharing directvies in the master regions. Plus, definitely no tests for this. Comment at: clang/include/clang/AST/StmtOpenMP.h:1857 + /// true if current directive has inner cancel directive.

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, jfb, arphaman, guansong, jholewinski. Herald added a reviewer: jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70726 Files: clang/inclu