[PATCH] D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC

2019-11-22 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith closed this revision. dexonsmith added a comment. Pushed as 20d51b2f14ac4488f684f8fc57cb0ba718a6b91d . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70583/new/ https://reviews.llvm.org/D70583 ___

[PATCH] D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC

2019-11-22 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. > I have to assume there was a point in the past where they were just one > class, but it's been pretty confusing for a while. I think it's time to fix > it. Thanks! LGTM CHANGES SINCE LAST

[PATCH] D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC

2019-11-21 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: Bigcheese, jkorous, rsmith, bruno. Herald added subscribers: ributzka, kbarton, nemanjai. dexonsmith added a parent revision: D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC. Herald added a subscriber: wuzish. Fix the