dexonsmith closed this revision.
dexonsmith marked an inline comment as done.
dexonsmith added a comment.
Pushed as 20d51b2f14ac4488f684f8fc57cb0ba718a6b91d.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70556/new/
https://reviews.llvm.org/D70556
_
bruno accepted this revision.
bruno added a comment.
Nice! LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70556/new/
https://reviews.llvm.org/D70556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
Bigcheese accepted this revision.
Bigcheese added a comment.
This revision is now accepted and ready to land.
lgtm. Nice cleanup.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70556/new/
https://reviews.llvm.org/D70556
___
cfe-commits maili
dexonsmith marked 2 inline comments as done.
dexonsmith added inline comments.
Comment at: clang/include/clang/Lex/ModuleLoader.h:50
+// We failed to load the module, but we shouldn't cache the failure.
+OtherUncachedFailure,
};
jkorous wrote:
> Just a
jkorous added inline comments.
Comment at: clang/include/clang/Lex/ModuleLoader.h:50
+// We failed to load the module, but we shouldn't cache the failure.
+OtherUncachedFailure,
};
Just a typo - the comma at the end.
CHANGES SINCE LAST ACTION
https
dexonsmith marked 2 inline comments as done.
dexonsmith added inline comments.
Comment at: clang/include/clang/Frontend/CompilerInstance.h:801-804
+ ModuleLoadResult findOrCompileModuleAndReadAST(StringRef ModuleName,
+ SourceLocat
dexonsmith created this revision.
dexonsmith added reviewers: bruno, Bigcheese, jkorous, rsmith.
Herald added a subscriber: ributzka.
Refactor the logic on CompilerInstance::loadModule and a couple of
surrounding methods in order to clarify what's going on.
- Rename ModuleLoader::loadModuleFromSo
