[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

2022-01-19 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D70549#3256063 , @JonChesterfield wrote: > @ABataev @jhuber6 and I would like to change this to annotate variables with > whatever visibility the user asked for. > > Can you recall if the concern about premption here was for t

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

2022-01-19 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added subscribers: jhuber6, JonChesterfield. JonChesterfield added a comment. Herald added subscribers: asavonic, sstefan1, yaxunl. @ABataev @jhuber6 and I would like to change this to annotate variables with whatever visibility the user asked for. Can you recall if the concern a

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

2019-11-25 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbbc328c62430: [OPENMP]Fix PR41826: symbols visibility in device code. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70549/new/ https:

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

2019-11-25 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70549/new/ https://reviews.llvm.org/D70549

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

2019-11-21 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added a subscriber: guansong. Herald added a project: clang. Currently, we ignore all locality attributes/info when building for the device and thus all symblos are externally visible and can be preemted at the runtime. It