[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe841029aef74: [clangd] Fix diagnostic location for macro expansions (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70494/new/ https:/

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

kadircet updated this revision to Diff 230849. kadircet marked an inline comment as done. kadircet added a comment. - Group similar tests together Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70494/new/ https://reviews.llvm.org/D70494 Files: cl

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:961 TEST(IgnoreDiags, FromNonWrittenInclude) { TestTU TU = TestTU::withCode(""); ---

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

merge_guards_bot added a comment. Build result: pass - 60220 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

kadircet updated this revision to Diff 230636. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70494/new/ https://reviews.llvm.org/D70494 Files: clang-tools-ex

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:121 const SourceManager &SM = Info.getSourceManager(); + const SourceLocation &DiagLoc = SM.getFileLoc(Info.getLocation()); SourceLocation Includ

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

hokein added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:121 const SourceManager &SM = Info.getSourceManager(); + const SourceLocation &DiagLoc = SM.getFileLoc(Info.getLocation()); SourceLocation IncludeInMainFile; should we use g

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

merge_guards_bot added a comment. Build result: pass - 60059 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Diagnostic locations were broken when it was result of a macro expansion. This patch fixes it by using exp