[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdecdbc1155f5: [clangd] Use expansion location when the ref is inside macros. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70480/new/

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

merge_guards_bot added a comment. Build result: pass - 60625 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein updated this revision to Diff 232853. hokein added a comment. add a fixme. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70480/new/ https://reviews.llvm.org/D70480 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp clang-tools-ex

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70480/new/ https://reviews.llvm.org/D70480 _

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) == SM.getMainF

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) == SM.getMainF

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

merge_guards_bot added a comment. Build result: pass - 60296 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) == SM.getMainFileID()

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein updated this revision to Diff 230905. hokein marked 2 inline comments as done. hokein added a comment. address comments - add related test for ast-based xrefs - add comments to clarify using different location for symbols/references. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:659 + TYPE(TYPE([[Foo]])) foo3; + [[CAT]](Fo, o) foo4; +} Previously we would not report any

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) == SM.getMainF

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

merge_guards_bot added a comment. Build result: pass - 60164 tests passed, 0 failed and 731 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) == SM.getMainFileID()

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein updated this revision to Diff 230249. hokein marked 3 inline comments as done. hokein added a comment. add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70480/new/ https://reviews.llvm.org/D70480 Files: clang-tools-extra/clang

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

merge_guards_bot added a comment. Build result: pass - 60164 tests passed, 0 failed and 731 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) == SM.getMainF

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Previously, xrefs has inconsistent behavior when the reference is inside macro body: - AST-based xrefs (for main file) us