This revision was automatically updated to reflect the committed changes.
Closed by commit rG8805316172a6: [clangd] Speed up when building rename edit.
(authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70441/new/
https://reviews.ll
hokein updated this revision to Diff 230264.
hokein added a comment.
update the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70441/new/
https://reviews.llvm.org/D70441
Files:
clang-tools-extra/clangd/refactor/Rename.cpp
clang-tools-extr
hokein updated this revision to Diff 230261.
hokein marked 3 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70441/new/
https://reviews.llvm.org/D70441
Files:
clang-tools-extra/cla
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:453
+ auto Offset = [&](const Position &P) -> llvm::Expected {
+Position Shifted = {
+
hokein added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.h:54
+/// Use of UTF-16 may be overridden by kCurrentOffsetEncoding.
+llvm::Expected byteOffset(StringRef LineCode, int LSPCharacter);
+
ilya-biryukov wrote:
> How this is different fro
hokein updated this revision to Diff 230242.
hokein marked 2 inline comments as done.
hokein added a comment.
Herald added a subscriber: mgrang.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70441/new/
https://reviews.llvm.org/D70
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.h:54
+/// Use of UTF-16 may be overridden by kCurrentOffsetEncoding.
+llvm::Expected byteOffset(StringRef LineCode, int LSPCharacter);
+
How this is different from `positionToOff
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
We used to scan the code everytime when computing the LSP position to the offset
(respect the LSP encoding).
Repository:
