[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

2019-12-04 Thread Andrew Gallagher via Phabricator via cfe-commits
andrewjcg updated this revision to Diff 232190. andrewjcg added a comment. rebase onto monorepo and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70219/new/ https://reviews.llvm.org/D70219 Files: clang/include/clang/Frontend/ASTUnit

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

2019-12-04 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added a comment. This seems like a outright improvement, but as mentioned above it would be nice to get @rsmith's take on it since I'm not an expert. Two nitpicks, though: 1. Could you please run clang-format on the lines you added/modified? 2. Could you apply these changes on top of t

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

2019-11-14 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Looks reasonable to me, but I don't know a great deal about the PrebuiltModuleFiles & so I'd like @rsmith to at least glance at/approve this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70219/new/ https://reviews.llvm.org/D70219 __

[PATCH] D70219: Make `-fmodule-file==` apply to .pcm file compilations

2019-11-13 Thread Andrew Gallagher via Phabricator via cfe-commits
andrewjcg created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When precompiling a header module, `-fmodule-file=name>=` flags can be used to provide an updated path to a module, which allows modules to be moved from the location they were compiled against.