[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

2019-11-21 Thread Artem Dergachev via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0b58b80edb81: [analyzer] Fix Objective-C accessor body farms after 2073dd2d. (authored by dergachev.a). Repository: rG

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

2019-11-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I'll commit in order to get rid of the crash, but i'm open for discussions :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70158/new/ https://reviews.llvm.org/D70158 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

2019-11-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 229437. NoQ added a comment. I discovered another problem related to this patch, which turned out to be a crash (serious!), so here's an update. We're crashing on roughly the following idiom: @interface I : NSObject @property NSObject *o; @end ​ @impl

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

2019-11-13 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. > In the affected test D68108 causes stubs of > getter and setter methods for property 'x' appear in both ObjCInterfaceDecl > and ObjCImplementationDecl for our toy ClassWithProperties. Previously they > were only present in ObjCInterfa

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

2019-11-12 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ marked 2 inline comments as done. NoQ added inline comments. Comment at: clang/test/Analysis/Inputs/expected-plists/nullability-notes.m.plist:225 -14 -16 -17 +26 +30 `26` is the new `10`. Comment at: clang/test/Ana

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

2019-11-12 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, aprantl. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, JDevlieghere, szepet, baloghadamsoftware, kristof.beyls, xazax.hun. Herald added a project: clang. NoQ marked 2 inline co