[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

dexonsmith closed this revision. dexonsmith marked 2 inline comments as done. dexonsmith added a comment. Committed 83dcb34b6bf4c175040b18d3e8c3c468418009fc . Thanks for the reviews! Comment at: clang/lib/S

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM with some minor comment below! Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:78 +def err_module_file_missing_definition : Error< + "module file '%

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

dexonsmith marked 2 inline comments as done. dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:78 +def err_module_file_missing_definition : Error< + "module file '%0' is missing the main module's definition">, DefaultFatal;

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

bruno added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:78 +def err_module_file_missing_definition : Error< + "module file '%0' is missing the main module's definition">, DefaultFatal; aprantl wrote: > Should this be

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

aprantl added a comment. Do we want to bother with a testcase for this? Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:78 +def err_module_file_missing_definition : Error< + "module file '%0' is missing the main module's definition">, DefaultFatal;

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

dexonsmith updated this revision to Diff 228626. dexonsmith added a comment. Updated to use a new diagnostic (`err_module_file_missing_definition`) that includes the filename of the PCM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70063/new/ https://reviews.llvm.org/D70063 Files:

[PATCH] D70063: clang/Modules: Error if ReadASTBlock does not find the main module

dexonsmith created this revision. dexonsmith added reviewers: aprantl, bruno, Bigcheese. Herald added a subscriber: ributzka. dexonsmith added parent revisions: D70055: clang/Modules: Clean up modules on error in ReadAST, D70056: clang/Modules: Split loop in ReadAST between failable and not, D700