[PATCH] D70057: clang/Modules: Add missing diagnostics for malformed AST files

2019-11-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith closed this revision. dexonsmith added a comment. Committed 8e2c192e2af8c760152ba3b28e774dbb1548e4aa . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70057/new/ https://reviews.llvm.org/D70057 ___

[PATCH] D70057: clang/Modules: Add missing diagnostics for malformed AST files

2019-11-11 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Serialization/ASTReader.cpp:3412 + if (ParseLineTable(F, Record)) { +Error("malformed SOURCE_MANAGER_LINE_TABLE in AST file");

[PATCH] D70057: clang/Modules: Add missing diagnostics for malformed AST files

2019-11-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: aprantl, bruno, Bigcheese. Herald added a subscriber: ributzka. These were found via an audit. In the case of `ParseLineTable` this is actually dead code, since parsing the line table always succeeds, but it's prudent to be defensive s