Mordante added a comment.
@aaron.ballman good catch, I've fixed it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70047/new/
https://reviews.llvm.org/D70047
___
cfe-commits mailing list
cfe-commits@lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rG964842861c8a: [Analyzer] Use a reference in a range-based
for (authored by Mordante).
Changed prior to commit:
https://reviews.llvm.org/D70047?vs=228582&id=228935#toc
Repository:
rG LLVM Github Monor
Szelethus accepted this revision.
Szelethus added a comment.
Whoo!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70047/new/
https://reviews.llvm.org/D70047
___
cfe-commits mailing list
cfe-commits@list
NoQ added a comment.
Yay thanks, i always forget those :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70047/new/
https://reviews.llvm.org/D70047
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM but the `&` should bind to the variable, not to the type, so that should
be corrected before committing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Mordante created this revision.
Mordante added reviewers: dcoughlin, aaron.ballman, xbolva00.
Mordante added a project: clang.
Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
Let the checkers use a reference ins