[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 __

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp:28 + )cpp", + // FIXME: Locating macro in duplicate definitions doesn't work. Enable + // this once LocateMacro is fix

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229836. usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tool

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

hokein added a comment. Thanks, looks mostly good, a few more nits. Comment at: clang-tools-extra/clangd/CollectMacros.h:91-92 Out.Names.insert(MacroNameTok.getIdentifierInfo()->getName()); - Out.Ranges.push_back(*Range); + if (auto SID = + getSym

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229535. usaxena95 added a comment. Minor change: Resued variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tools-extra/clangd/CollectMacros.h

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229529. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Modified tests for better error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D7000

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp:80 +<< Test; +EXPECT_THAT(collectKnownReferences(AST.getMacros()), AreMacroRefsFrom(T)) +<< Test; hokein wrote: > usaxena95 wrote: > > hokei

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 60093 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229492. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Uploading latest patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-t

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

hokein added a comment. looks like you forgot to upload the latest patch. Comment at: clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp:80 +<< Test; +EXPECT_THAT(collectKnownReferences(AST.getMacros()), AreMacroRefsFrom(T)) +<< Test;

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 marked 7 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:898 + // Handle macros. + if (auto Macro = locateMacroAt(Loc, AST.getPreprocessor())) { +if (auto MacroSID = getSymbolID(Macro->Name, Macro->Info, SM)

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:29 std::vector Ranges; + llvm::DenseMap> MacroRefs; }; usaxena95 wrote: > hokein wrote: > > I think the `Ranges` and `MacrosRefs` have a lot of duplications, it is > > wastef

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 59989 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 59989 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 228870. usaxena95 added a comment. Fixed typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tools-extra/clangd/CollectMacros.h clang-tools-extra/

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:29 std::vector Ranges; + llvm::DenseMap> MacroRefs; }; hokein wrote: > I think the `Ranges` and `MacrosRefs` have a lot of dupli

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 228869. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Herald added a subscriber: mgorny. Added tests for CollectMacros.h Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

merge_guards_bot added a comment. Build result: pass - 59967 tests passed, 0 failed and 763 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:898 + // Handle macros. + if (auto Macro = locateMacroAt(Loc, AST.getPreprocessor())) { +if (auto MacroSID = getSymbolID(Macro->Name, Macro->Info, SM)) { hokein wrote: > this is

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 228679. usaxena95 marked an inline comment as done. usaxena95 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tools-extra/clang

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:29 std::vector Ranges; + llvm::DenseMap> MacroRefs; }; I think the `Ranges` and `MacrosRefs` have a lot of duplications, it is wasteful to store a same range twice. We don't

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 228456. usaxena95 added a comment. Removing changes from different patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. usaxena95 added a project: clang. This patch adds the cross references for Macros in the MainFile. We add references for the main file to the ParsedAST. We query the references from it using the SymbolID. Xref outside main file w

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 added a comment. Please ignore the changes from patch https://reviews.llvm.org/D69937 Will fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 _