[PATCH] D69996: [clangd] Fixed colon escaping on Windows

2019-11-08 Thread liu hui via Phabricator via cfe-commits
lh123 marked 2 inline comments as done. lh123 added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:128 +this.highlighter.highlight( +vscode.Uri.parse(params.textDocument.uri).toString(), lines); } -

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

2019-11-08 Thread liu hui via Phabricator via cfe-commits
lh123 updated this revision to Diff 228421. lh123 added a comment. address comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: package.json src/semantic-highlighting.ts Index: src/semantic-highlighting.ts

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

2019-11-08 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:128 +this.highlighter.highlight( +vscode.Uri.parse(params.textDocument.uri).toString(), lines); } Could we accept a `URI`

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

2019-11-08 Thread liu hui via Phabricator via cfe-commits
lh123 updated this revision to Diff 228405. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: clang-tools-extra/clangd/clients/clangd-vscode/package.json clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts Index:

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

2019-11-08 Thread liu hui via Phabricator via cfe-commits
lh123 updated this revision to Diff 228397. lh123 added a comment. Remove irrelevant files from the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: clang-tools-extra/clangd/clients/clangd-vscode/package.json clang-tools-extra/cl

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

2019-11-08 Thread liu hui via Phabricator via cfe-commits
lh123 updated this revision to Diff 228393. lh123 added a comment. update diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: clang-tools-extra/clangd/clients/clangd-vscode/1.patch clang-tools-extra/clangd/clients/clangd-vscode/packa

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

2019-11-08 Thread liu hui via Phabricator via cfe-commits
lh123 planned changes to this revision. lh123 added a comment. it will cause whitspace escaped problem. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 ___ cfe-c

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

2019-11-08 Thread liu hui via Phabricator via cfe-commits
lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov, hokein. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. vscode always escapes the colon on the file uri, w