[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ added a comment. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/16031 MSan doesn't catch it >.< Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69962/new/ https://reviews.llvm.org/D69962

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bbca3411b38: [CFG] Add a test for a flaky crash in CFGBlock::getLastCondition(). (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D69962?vs=228292&id=230575#toc Repository:

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Szelethus added a comment. In D69962#1744679 , @NoQ wrote: > In D69962#1742291 , @Szelethus wrote: > > > Try to add a non-sanitizer built tablegen: > > `-DCLANG_TABLEGEN=/path/to/non/sanitized/clang-tblgen` > > `-

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ added a comment. In D69962#1742291 , @Szelethus wrote: > Try to add a non-sanitizer built tablegen: > `-DCLANG_TABLEGEN=/path/to/non/sanitized/clang-tblgen` > `-DLLVM_TABLEGEN=/path/to/non/sanitized/llvm-tblgen` Yay nice! The clang that i built thi

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Szelethus added a comment. Accepted accidentally. Well, in any case, I trust your judgement on this! I'd prefer not to commit the test file as-is. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69962/new/ https://reviews.llvm.org/D69962 ___

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D69962#1741503 , @NoQ wrote: > In D69962#1739440 , @NoQ wrote: > > > In D69962#1738618

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ added a comment. In D69962#1739440 , @NoQ wrote: > In D69962#1738618 , @Szelethus wrote: > > > Nice catch! Though, wouldn't the memory sanitizer buildbots break on this > > reliably? > > > I kinda hope so; i'll

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ marked an inline comment as done. NoQ added a comment. In D69962#1738618 , @Szelethus wrote: > Nice catch! Though, wouldn't the memory sanitizer buildbots break on this > reliably? I kinda hope so; i'll take a look at home. Comme

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Szelethus added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:5882 + // FIXME: Should we return the terminator here? + if (size() == 0) What would that even be? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69962/ne

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Szelethus added a comment. Nice catch! Though, wouldn't the memory sanitizer buildbots break on this reliably? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69962/new/ https://reviews.llvm.org/D69962 ___ cfe-commits

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/test/Analysis/a_flaky_crash.cpp:19 + +// 256 copies of the same run-line to make it crash more often when it breaks. + This is a trade-off between reliability and not increasing te

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added a project: clang. Herald added a subscriber: cfe-commits. Using an end iterator of an empty CFG block boiled down to dereferencing a garbage pointer.