[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rGc63f1b160eb6: [DeclCXX] Remove unknown external linkage specifications (authored by ekatz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ https:/

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good - thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ https://reviews.llvm.org/D69935 ___ cfe-commits mailin

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz updated this revision to Diff 228860. ekatz added a comment. In D69935#1741995 , @uabelho wrote: > In D69935#1739235 , @dblaikie wrote: > > > In D69935#1738273 , @uabel

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

uabelho added a comment. In D69935#1739235 , @dblaikie wrote: > In D69935#1738273 , @uabelho wrote: > > > Don't you need to also remove > > > > case LinkageSpecDecl::lang_cxx_11: > > case LinkageSpecDecl::lang_c

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. In D69935#1741268 , @dblaikie wrote: > In D69935#1739235 , @dblaikie wrote: > > > +1 to this & then it seems fine (probably without a committed test, but I > > wouldn't mind a copy/paste of c

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie added a comment. In D69935#1739235 , @dblaikie wrote: > In D69935#1738273 , @uabelho wrote: > > > Don't you need to also remove > > > > case LinkageSpecDecl::lang_cxx_11: > > case LinkageSpecDecl::lang_

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz updated this revision to Diff 228755. ekatz added a comment. Removed DWARF reference from LinkageSpecDecl::LanguageIDs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ https://reviews.llvm.org/D69935 Files: clang/include/clang/AST/DeclCXX.h clang/lib/AST/DeclPrinter.

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

rsmith added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:2762 /// ensure a stable ABI for this, we choose the DW_LANG_ encodings /// from the dwarf standard. enum LanguageIDs { Using DWARF encodings here does nothing for AST format sta

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. No problem. For the source code: extern "C++11" int x; In clang 9.0 the compilation fails with the message: :1:8: error: unknown linkage language extern "C++11" int x; ^~~ 1 error generated. while on the trunk it just pass without any error. Reposi

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie added a comment. In D69935#1738273 , @uabelho wrote: > Don't you need to also remove > > case LinkageSpecDecl::lang_cxx_11: > case LinkageSpecDecl::lang_cxx_14: > > > from VisitLinkageSpecDecl in clang-tools-extra/modularize/Modularize.cpp?

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

SouraVX added a comment. In D69935#1738563 , @ekatz wrote: > In D69935#1738311 , @SouraVX wrote: > > > I created that patch, for purpose of emitting C++ language standards C++11, > > C++14 in the debug information

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. In D69935#1738311 , @SouraVX wrote: > I created that patch, for purpose of emitting C++ language standards C++11, > C++14 in the debug information to be available for consumer's[GDB,LLDB]. > DW_TAG_lang_c_plus_plus_11 .. 14 --new

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

SouraVX added a comment. I created that patch, for purpose of emitting C++ language standards C++11, C++14 in the debug information to be available for consumer's[GDB,LLDB]. DW_TAG_lang_c_plus_plus_11 .. 14 --new tags for languages in DWARF5. Sorry, I think, I missed this unintended additions in

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

uabelho added a comment. Don't you need to also remove case LinkageSpecDecl::lang_cxx_11: case LinkageSpecDecl::lang_cxx_14: from VisitLinkageSpecDecl in clang-tools-extra/modularize/Modularize.cpp? (added in r372714 / e07376a320d to silence a clang warning). I can't see how that code would

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. Yes, these changes regard to the same thing - the removal of the "Linkage-Spec LanguageIDs". As you described it nicely, it is for linkage only, meaning C vs C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69935/new/ htt

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie added a comment. In D69935#1737615 , @ekatz wrote: > With this change (current trunk) you can write code as follows: > > extern "C++11" int x; > > > And it will pass compilation. No other compiler support it, nor it should, as > there is no suc

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. With this change (current trunk) you can write code as follows: extern "C++11" int x; And it will pass compilation. No other compiler support it, nor it should, as there is no such thing as `extern "C++11"` nor `extern "C++14"`. Repository: rG LLVM Github Monorepo

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

dblaikie added a comment. "The change introduced new external linkage languages ("C++11" and "C++14") which not supported in C++." Could you describe more what you mean by "not supported in C++"? These identifiers aren't part of the C++ standard/they're an implementation detail of the compiler

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz created this revision. ekatz added reviewers: SouraVX, aprantl, dblaikie, JDevlieghere, uabelho, rsmith. ekatz added a project: clang. Herald added a subscriber: cfe-commits. Partial revert of r372681 "Support for DWARF-5 C++ language tags". The change introduced new external linkage langu