Re: [PATCH] D69897: Add #pragma clang loop aligned

On Wed, Nov 6, 2019 at 10:43 PM Hal Finkel via Phabricator < revi...@reviews.llvm.org> wrote: > hfinkel added inline comments. > > > > Comment at: clang/docs/LanguageExtensions.rst:3135 > + > +This predicates all the array references inside the loop to be aligned. > The aligned ac

[PATCH] D69897: Add #pragma clang loop aligned

Meinersbur added a comment. In D69897#1735983 , @lebedev.ri wrote: > It would be really best if this could just make use of > `CodeGenFunction::EmitAlignmentAssumption()`, > else this is a heavy hammer with loose handle. Since it is a property of the d

[PATCH] D69897: Add #pragma clang loop aligned

lebedev.ri added a comment. In D69897#1735961 , @Meinersbur wrote: > Please see my comments in D69900 as well. > > For the font-end side, I suggest the syntax `vectorize_assume_alignment(32)` > instead. We also need to de

[PATCH] D69897: Add #pragma clang loop aligned

Meinersbur added a comment. Please see my comments in D69900 as well. For the font-end side, I suggest the syntax `vectorize_assume_alignment(32)` instead. We also need to define what this assumes to be aligned. The first element of the array? Every array eleme

[PATCH] D69897: Add #pragma clang loop aligned

hfinkel added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3135 + +This predicates all the array references inside the loop to be aligned. The aligned access to them can increase fetch time and increase the performance. + hfinkel wrote: > lebe

[PATCH] D69897: Add #pragma clang loop aligned

hfinkel added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3135 + +This predicates all the array references inside the loop to be aligned. The aligned access to them can increase fetch time and increase the performance. + lebedev.ri wrote: > W

[PATCH] D69897: Add #pragma clang loop aligned

lebedev.ri added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3135 + +This predicates all the array references inside the loop to be aligned. The aligned access to them can increase fetch time and increase the performance. + What does this act

[PATCH] D69897: Add #pragma clang loop aligned

m-happy created this revision. m-happy added reviewers: hfinkel, DTharun, rscottmanley, Meinersbur. m-happy added a project: clang. Herald added subscribers: cfe-commits, zzheng. This patch adds functionality '#pragma clang loop aligned'. The load/store access in for loop following the '#pragma c