This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG443ab4d2e012: [clang][Basic] Integrate SourceLocation with
FoldingSet, NFCI (authored by miyuki).
Repository:
rG LLVM Github Monorepo
CHANGES SIN
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1088
+ ID.Add(Range.getEnd());
+ ID.Add(static_cast(Loc));
}
miyuki wrote:
> dexonsmith wr
miyuki added inline comments.
Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1088
+ ID.Add(Range.getEnd());
+ ID.Add(static_cast(Loc));
}
dexonsmith wrote:
> I'm surprised you need this `static_cast`, can you explain why it was
> necessary?
`Loc` is an obj
dexonsmith added inline comments.
Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1088
+ ID.Add(Range.getEnd());
+ ID.Add(static_cast(Loc));
}
I'm surprised you need this `static_cast`, can you explain why it was necessary?
Repository:
rG LLVM Github Mon
miyuki updated this revision to Diff 300214.
miyuki added a comment.
Fixed linter errors.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69844/new/
https://reviews.llvm.org/D69844
Files:
clang/include/clang/Basic/SourceLocation.h
clang/lib/Anal
miyuki updated this revision to Diff 300049.
miyuki added a comment.
Reverted accidentally removed chunk.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69844/new/
https://reviews.llvm.org/D69844
Files:
clang/include/clang/Basic/SourceLocation.h
miyuki updated this revision to Diff 300044.
miyuki retitled this revision from "[Basic] Integrate SourceLocation and
SourceRange with FoldingSet, NFCI" to "[clang][Basic] Integrate SourceLocation
with FoldingSet, NFCI".
miyuki edited the summary of this revision.
miyuki added a comment.
Address
