[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2020-10-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. Yes, I am still interested in working on this. For now, I've split out some changes that don't require any modifications in `SourceLocation` into https://reviews.llvm.org/D89705. > A general comment is that there are a couple of functional changes in this > patch, where

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2020-10-16 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Herald added a subscriber: sstefan1. If you're still interested in pursuing this, I'm happy to review it. A general comment is that there are a couple of functional changes in

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2020-03-10 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 249443. miyuki added a comment. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, kbarton, nemanjai. Rebased, updated several more hash map occurrences. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.or

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2020-01-17 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2019-12-02 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl resigned from this revision. aprantl added a comment. @rsmith can you take a look at this to see if this is going into the right direction? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 __

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2019-12-02 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2019-11-22 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping^2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2019-11-14 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2019-11-05 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. The motivation is to be able to make source locations' underlying type configurable. Richard Smith suggested that this might be feasible: http://lists.llvm.org/pipermail/cfe-dev/2019-October/063515.html So, the first step is to get rid of getRawEncoding where possible. I

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2019-11-05 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. What's the motivation behind this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2019-11-05 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki updated this revision to Diff 227894. miyuki added a comment. Changed getRawEncoding -> getHashValue in Sema.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 Files: clang/include/clang/Basic/SourceLocation.h clang/include/clang/Edit/

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

2019-11-05 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: aprantl, rsmith, faisalv. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. miyuki edited reviewers, added: JDevlieghere; removed: jdoerfert. Herald added a reviewer: jdoerfert. This chan