[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz updated this revision to Diff 227917. ekatz added a comment. Fixed requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 Files: clang/lib/Lex/LiteralSupport.cpp llvm/include/llvm/ADT/APFloat.h llvm/lib/MC/MCParser/AsmPar

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz marked 2 inline comments as done. ekatz added inline comments. Comment at: llvm/lib/Support/APFloat.cpp:273 + if (p != end) +return createError("Invalid exponent in exponent"); arsenm wrote: > Error message sounds like nonsense It is actually incorr

[PATCH] D69770: Add recoverable string parsing errors to APFloat

arsenm added inline comments. Comment at: llvm/lib/Support/APFloat.cpp:273 + if (p != end) +return createError("Invalid exponent in exponent"); Error message sounds like nonsense Comment at: llvm/unittests/ADT/APFloatTest.cpp:1322 + EX

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz created this revision. ekatz added reviewers: chandlerc, lattner, rsmith. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya, nhaehnle, jvesely, arsenm. Herald added projects: clang, LLVM. Implementing the APFloat part in PR4745. Repository: rG LLVM Github Monore