[PATCH] D69764: [clang-format] Add East Const / West Const fixer

aaron.ballman added a comment. In D69764#1732295 , @MyDeveloperDay wrote: > In D69764#1732235 , @aaron.ballman > wrote: > > > I like the functionality, but am slightly opposed to using "east/west" > > terminology

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay added a comment. In D69764#1732235 , @aaron.ballman wrote: > I like the functionality, but am slightly opposed to using "east/west" > terminology -- that's not a ubiquitous phrase and it takes a bit of thinking > before it makes sense. I

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

aaron.ballman added a comment. I like the functionality, but am slightly opposed to using "east/west" terminology -- that's not a ubiquitous phrase and it takes a bit of thinking before it makes sense. I think "left/right" is likely to be more universally understood. Also, should this apply to

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay added a subscriber: pollydev. MyDeveloperDay added a comment. @pollydev too (a previously clang-format clean directory) will generate changes running `clang-format --const-style=west -i -n *.cpp` ScopBuilder.cpp:74:9: warning: code should be clang-formatted [-Wclang-format-viol

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay added a comment. An example of even how setting the style to be West will generate new changes on a previously formatted lib/Format $ git diff . diff --git a/clang/lib/Format/WhitespaceManager.cpp b/clang/lib/Format/WhitespaceManager.cpp old mode 100644 new mode 100755

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:768 LLVMStyle.CommentPragmas = "^ IWYU pragma:"; + LLVMStyle.ConstStyle = FormatStyle::CS_Leave; LLVMStyle.CompactNamespaces = false;

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/Format/Format.cpp:768 LLVMStyle.CommentPragmas = "^ IWYU pragma:"; + LLVMStyle.ConstStyle = FormatStyle::CS_Leave; LLVMStyle.CompactNamespaces = false; MyD

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:768 LLVMStyle.CommentPragmas = "^ IWYU pragma:"; + LLVMStyle.ConstStyle = FormatStyle::CS_Leave; LLVMStyle.CompactNamespaces = false;

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

lebedev.ri added inline comments. Comment at: clang/lib/Format/Format.cpp:768 LLVMStyle.CommentPragmas = "^ IWYU pragma:"; + LLVMStyle.ConstStyle = FormatStyle::CS_Leave; LLVMStyle.CompactNamespaces = false; Based on code reviews, this should be `CS_West`.

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay added a comment. A demo of `clang-format -i --const-style=east *.cpp *.h` being run on clang/lib/Format can be see here D69780: [clang-format] DO NOT COMMIT - Demo of East/West Const Fixer on clang-format CHANGES SINCE LAST ACTION https://rev

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay updated this revision to Diff 227637. MyDeveloperDay added a comment. Support for template object const type declarations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/incl

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, sammccall, owenpan, krasimir. MyDeveloperDay added a project: clang-format. Herald added a subscriber: mgorny. Herald added a project: clang. Developers these days seem to argue over east vs west const