[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

MaskRay added a comment. > Patch by sthibaul (Samuel Thibault) @kristina As a belated advice... since LLVM has moved from svn to git, we can ask contributors's names and emails, and then do `git commit --amend --author 'name '` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina added a comment. For future - Since you seem to put up a lot of (well, almost all) patches related to Hurd support, may I suggest requesting commit access so you can land patches yourself after review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGb18cb9c47166: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default (authored by kristina). Repository:

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. > Let me know if you need this committed. Yes, please commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina accepted this revision. kristina added a comment. On second look this seems to be caused by `compiler-rt` being used as the default runtime, which is not accounted for in that particular test. Test is expecting a GCCesque crtbegin here which is missing with `compiler-rt`: "crt1.o" "c

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. (I don't see anything looking like what you have, so can't investigate) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. I am actually getting many failures with ninja check-all on my build box: Expected Passes: 56258 Expected Failures : 203 Unsupported Tests : 1485 Unexpected Failures: 164 I have attached the whole check log: F11178531: check.log

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina added a comment. I ran `check-clang` on a x86_64 Ubuntu 18.04 machine (toolchain compiled with `compiler-rt` as the default CRT and `libc++`/`libc++abi`/`libunwind_llvm`). I think one of the driver tests for multilib stuff may be broken, in which case it should probably be investigated

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. Which checksuite are you running? I had been using ninja check-all, and I do indeed get unexpected failures, but exactly the same set of failures as when building against master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.or

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina requested changes to this revision. kristina added a comment. Sorry for responding late, was away. This seems to be tripping up a regression test: FAIL: Clang :: Driver/cross-linux.c (5312 of 16608) llvm-project/clang/test/Driver/cross-linux.c:62:26: error: CHECK-MULTI32-X86-64: ex

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul marked an inline comment as done. sthibaul added a comment. > [Gnu toolchain] > maybe this can be removed in the title? I thought that commits usually have such kind of title prefixes? Comment at: clang/lib/Driver/ToolChains/Linux.cpp:36 /// /// Debian-based system

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sylvestre.ledru requested changes to this revision. sylvestre.ledru added a comment. This revision now requires changes to proceed. //[Gnu toolchain] // maybe this can be removed in the title? Comment at: clang/lib/Driver/ToolChains/Linux.cpp:36 /// /// Debian-based systems a

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul added a comment. I have updated the patch to the latest git and re-ran checks. Could somebody have a look at it please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits maili

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul updated this revision to Diff 235644. sthibaul marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/Gnu.h clang/lib/Driver/ToolChain

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sylvestre.ledru added a comment. @kristina can we land this patch ? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul updated this revision to Diff 229192. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69758/new/ https://reviews.llvm.org/D69758 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/Gnu.h clang/lib/Driver/ToolChains/Hurd.cpp clang/lib/Driver/ToolChains/Hu

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul marked 3 inline comments as done. sthibaul added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2623 + int MaxVersion = 0; + std::string MaxVersionString = ""; + for (llvm::vfs::directory_iterator LI = vfs.dir_begin(base, EC), LE; kr

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2623 + int MaxVersion = 0; + std::string MaxVersionString = ""; + for (llvm::vfs::directory_iterator LI = vfs.dir_begin(base, EC), LE; sthibaul wrote: > kristina wrote: > > No need

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul marked an inline comment as done. sthibaul added a comment. Not sure what NFCI means, but for Linux the behavior should just not change at all, and the testsuite indeed behaved exactly the same on Linux indeed. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2623 + i

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

kristina added reviewers: mclow.lists, ldionne, EricWF, rsmith. kristina added a comment. Herald added a subscriber: dexonsmith. Added libcxx maintainers, would like one of them to sign off on this. I presume this is NFCI for Linux so it should be covered by existing regression tests?

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sthibaul created this revision. sthibaul added a reviewer: kristina. Herald added a project: clang. Herald added a subscriber: cfe-commits. Linux' current addLibCxxIncludePaths and addLibStdCxxIncludePaths are actually almost non-Linux-specific at all, and can be reused almost as such for all gcc