[PATCH] D69740: [profile] Support counter relocation at runtime

2022-04-28 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added inline comments. Herald added subscribers: abrachet, MaskRay. Herald added a project: All. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:673 +auto *Add = Builder.CreateAdd(Builder.CreatePtrToInt(Addr, Int64Ty), LI); +Addr = Builder.CreateI

[PATCH] D69740: [profile] Support counter relocation at runtime

2020-01-17 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd3db13af7e5c: [profile] Support counter relocation at runtime (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D69740?vs=238689&id=238901#toc Repository: rG LLVM Github Monorep

[PATCH] D69740: [profile] Support counter relocation at runtime

2020-01-16 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 238689. phosek marked an inline comment as done. phosek added a comment. Addressed the comment and also added a test for Linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69740/new/ https://reviews.llvm.org/D

[PATCH] D69740: [profile] Support counter relocation at runtime

2019-12-02 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm with a small cleanup. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:674 + if (isRuntimeCounterRelocationEnabled()) { +Type *Int64Ty = Type::getInt64T

[PATCH] D69740: [profile] Support counter relocation at runtime

2019-11-22 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D69740#1752348 , @vsk wrote: > I think this looks good overall. The only high-level item that seems to be > missing is Fuchsia testing -- are there any bots for this? Not yet unfortunately, it's something I'm slowly working on

[PATCH] D69740: [profile] Support counter relocation at runtime

2019-11-22 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 230733. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69740/new/ https://reviews.llvm.org/D69740 Files: clang/docs/SourceBasedCodeCoverage.rst clang/lib/Driver/ToolChains/Darwin.cpp compiler-rt/lib/profile/

[PATCH] D69740: [profile] Support counter relocation at runtime

2019-11-22 Thread Petr Hosek via Phabricator via cfe-commits
phosek updated this revision to Diff 230727. phosek marked 2 inline comments as done. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69740/new/ https://reviews.llvm.org/D69740 Fil