[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

arsenm closed this revision. arsenm added a comment. c6da9ec0e90ea8798ecae583bb8d26bdf6b9b79f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69666/new/ https://reviews.llvm.org/D69666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69666/new/ https://reviews.llvm.org/D69666 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

jdoerfert added a comment. Communication problem: > This attempted to always use the default address space void pointer type > instead of preserving the source address space. Where "This" is the old code. Replace "This" in the commit message with some more descriptive wording and the confusion

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

arsenm added a comment. In D69666#1728946 , @yaxunl wrote: > Is the description reversed? > > This attempts to preserve the source address space instead of always using > the default address space for void pointer type. I don't think so? This now preser

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

yaxunl added a comment. Is the description reversed? This attempts to preserve the source address space instead of always using the default address space for void pointer type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69666/new/ https://reviews.llvm.org/D69666

[PATCH] D69666: clang: Fix assert on void pointer arithmetic with address_space

arsenm created this revision. arsenm added reviewers: yaxunl, jdoerfert, Anastasia. Herald added a subscriber: wdng. This attempted to always use the default address space void pointer type instead of preserving the source address space. https://reviews.llvm.org/D69666 Files: clang/lib/CodeGe