NoQ added inline comments.
Comment at:
clang/test/Analysis/clangsa_unsupported_features/handle_constructors_for_lambda_captures.cpp:29
+ operator=(incr_on_copy_for_simple_usage &&o) = delete;
+ ~incr_on_copy_for_simple_usage() = default;
+};
NoQ wrote:
> That'
NoQ added a comment.
I recommend starting with CFG tests for this feature. I.e., do
`-analyzer-checker debug.DumpCFG` and make sure that every `CFGStmt` that
corresponds to a constructor is a `CFGConstructor` (i.e., has a
`ConstructionContext` explained in the dump). Cf.
`test/Analysis/cfg-ric
gamesh411 updated this revision to Diff 227096.
gamesh411 added a comment.
- Remove link reference from commit message
- Remove superfluous semicolons left in the code
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69602/new/
https://reviews.llvm.or
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
LGTM, can we remove the open projects entry under the same breath?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69602/new/
https://review
gamesh411 updated this revision to Diff 227090.
gamesh411 added a comment.
- Add capture by reference test
- Add another class to ensure reachability inside function call is independent
from each other in the first 2 test cases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
gamesh411 created this revision.
gamesh411 added reviewers: NoQ, Szelethus, baloghadamsoftware.
Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity.
Herald added a project: clang.
This test provides test coverage
