[PATCH] D69569: isBuiltinFunc() uses StringRef instead of const char*

2019-10-29 Thread Vlad Tsyrklevich via Phabricator via cfe-commits
vlad.tsyrklevich added a comment. Fix LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69569/new/ https://reviews.llvm.org/D69569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D69569: isBuiltinFunc() uses StringRef instead of const char*

2019-10-29 Thread Guillaume Chatelet via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1c85a2e8dc7e: isBuiltinFunc() uses StringRef instead of const char* (authored by gchatelet). Repository: rG LLVM Github

[PATCH] D69569: isBuiltinFunc() uses StringRef instead of const char*

2019-10-29 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet created this revision. gchatelet added a reviewer: vlad.tsyrklevich. Herald added a project: clang. Herald added a subscriber: cfe-commits. gchatelet edited the summary of this revision. This prevents a bug when passing `nullptr`, `StringRef` ctor would call `strlen(nullptr)`. This shou