[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

ldionne commandeered this revision. ldionne edited reviewers, added: jdoerrie; removed: ldionne. ldionne added a comment. Herald added subscribers: broadwaylamb, jkorous. In D69520#1878360 , @miscco wrote: > I believe this is superseded by the implementati

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Oh interesting! Yes, it looks like you are right. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

miscco added a comment. I believe this is superseded by the implementation of P1976R2 in D74577 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mail

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Friendly Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 227605. jdoerrie marked 4 inline comments as done. jdoerrie added a comment. Addressed Marshall's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/include/span libcxx/test/std/cont

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added inline comments. Comment at: libcxx/test/std/containers/views/span.cons/span.fail.cpp:78 - -// Try to remove const and/or volatile (static -> static) -{ mclow.lists wrote: > Ok. The comment here is wrong; this is testing dynamic -> static. >

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

mclow.lists added inline comments. Comment at: libcxx/test/std/containers/views/span.cons/span.fail.cpp:78 - -// Try to remove const and/or volatile (static -> static) -{ Ok. The comment here is wrong; this is testing dynamic -> static. However, why are you

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Thanks Jorg! Given that the status is still "Needs Review", I assume I also still need an LGTM from Marshall, Louis or Eric, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jorgbrown added a comment. +1 Thanks also for fixing the return statement of testConversionSpan() in span.pass.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list cfe-c

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Friendly Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 226714. jdoerrie added a comment. Full patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/include/span libcxx/test/std/containers/views/span.cons/span.fail.cpp libcxx/test/std/contain

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 226713. jdoerrie added a comment. Formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/test/std/containers/views/span.cons/span.pass.cpp Index: libcxx/test/std/containers/views/span.

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie created this revision. jdoerrie added reviewers: mclow.lists, ldionne. Herald added a reviewer: EricWF. Herald added subscribers: libcxx-commits, dexonsmith, christof. [libc++] Disallow dynamic -> static span conversions This change disallows dynamic to static span conversions. This comp