[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

2019-10-27 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. r40ab8ae9fb70f1550815bf0f867148b5101a4f66 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69494/new/ https://reviews.llvm.org/D69494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

2019-10-27 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. Ah, yes, missed this. Then just add a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69494/new/ https://reviews.llvm.org/D69494 __

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

2019-10-27 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D69494#1722868 , @ABataev wrote: > In D69494#1722867 , @arsenm wrote: > > > In D69494#1722853 , @ABataev wrote: > > > > > Tests? > > > > > > > > >

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

2019-10-27 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D69494#1722867 , @arsenm wrote: > In D69494#1722853 , @ABataev wrote: > > > Tests? > > > > > In D69494#1722853 , @ABataev wrote: > > > Tests? > >

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

2019-10-27 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D69494#1722853 , @ABataev wrote: > Tests? In D69494#1722853 , @ABataev wrote: > Tests? This is NFC and doesn't change any behavior. The test for the convergent attribute is already

[PATCH] D69494: OpenMP: Add helper function for convergent runtime calls

2019-10-27 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a reviewer: grokos. JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69494/new/ https://reviews.llvm.org/D69494 _