[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

2019-10-29 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. @rsmith also doesn't like the approach `runWithSufficientStackSpace` in D69479 . So I'll try to use a different approach. If that succeeds I have no use case for this patch and will probably abandon it. Repository: rG LLVM Github Mon

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

2019-10-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I sort of feel like we don't want to go this route because we want to avoid calling `runWithSufficientStackSpace` whenever possible, but I am not strongly opposed to this patch. It should be combined with the usage of the new functionality, however, so that it get

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

2019-10-27 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. The use case and its test are in D69479 . Is that sufficient? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69478/new/ https://reviews.llvm.org/D69478 __

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

2019-10-27 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Yes, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69478/new/ https://reviews.llvm.org/D69478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

2019-10-27 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Exact use case? Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69478/new/ https://reviews.llvm.org/D69478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D69478: [Sema] Allow warnStackExhausted to show more info

2019-10-27 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added reviewers: rnk, rsmith, aaron.ballman. Mordante added a project: clang. This allows the caller of the function to add a note about how to fix the stack exhaustion. This can be useful to aid the user. For example it can be used to show a help message