[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

ilya-biryukov added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69431/new/ https://reviews.llvm.org/D69431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit rGc814f4c4592c: [clangd] Do not highlight keywords in semantic highlighting (authored by ilya-biryukov). Changed prior to commit: https://reviews.llvm.org/D69431?vs=226419&id=226632#toc Repository: rG

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:233 - bool VisitTypeLoc(TypeLoc TL) { -if (auto K = kindForType(TL.getTypePtr())) il

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:233 - bool VisitTypeLoc(TypeLoc TL) { -if (auto K = kindForType(TL.getTypePtr())) hokein wrote: > as we are not visiting this base `TypeLoc` in this patch, w

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:233 - bool VisitTypeLoc(TypeLoc TL) { -if (auto K = kindForType(TL.getTypePtr())) as we are not visiting this base `TypeLoc` in this patch, will we miss any intere

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

merge_guards_bot added a comment. Build result: fail - 59585 tests passed, 2 failed and 805 were skipped. failed: Clangd.Clangd/semantic-highlighting.test failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt ,

[PATCH] D69431: [clangd] Do not highlight keywords in semantic highlighting

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Editors are good at highlightings the keywords themselves. Note that this only affects highlightings of builtin typ