dmgreen added a comment.
Ah, I see, that's why it was needed. That makes sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69426/new/
https://reviews.llvm.org/D69426
___
cfe-commits mailing list
cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rG11ce19d2119e: [clang] Switch arm-mve-intrinsics tests to use
%clang_cc1. (authored by simon_tatham).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69426/new/
simon_tatham added a comment.
There's no need, as far as I can see. `-fno-discard-value-names` is a driver
option only. On the cc1 command line the option is `-discard-value-names`, and
it has no negative form: you turn it off by not specifying it in the first
place, which indeed these command
dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.
Sounds good.
But make sure that -fno-discard-value-names is still included. Otherwise the
names like "entry" will not be output, so the tests fail in "non-assert" builds.
Repository:
rG
simon_tatham created this revision.
simon_tatham added a reviewer: dmgreen.
Herald added subscribers: cfe-commits, kristof.beyls.
Herald added a project: clang.
simon_tatham edited the summary of this revision.
It isn't really necessary for them to run the clang driver, and it's
more efficient not