[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

ebevhan added a comment. For what it's worth, in our downstream fork of Clang we have added the ability for function types to possess an address space. Though technically, even in our fork it is not possible to actually declare functions/function pointers with an address space; the target-speci

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

probinson added a subscriber: rsmith. probinson added a comment. In D69393#1729772 , @yonghong-song wrote: > During experimenting with linux kernel codes, I found that clang does not > allow address_space attribute for function pointers, specifically, in

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song added a comment. During experimenting with linux kernel codes, I found that clang does not allow address_space attribute for function pointers, specifically, in `clang/lib/Sema/SemaType.cpp`, // ISO/IEC TR 18037 S5.3 (amending C99 6.7.3): "A function type shall not be // quali

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song updated this revision to Diff 227400. yonghong-song edited the summary of this revision. yonghong-song added a comment. minor update to only support address_space 1 for user pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69393/n

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

probinson added a comment. In D69393#1720816 , @ast wrote: > > The address spaces envisioned by the Linux kernel appear to be more > > informational and not descriptive of hardware characteristics. > > From the kernel pov the `__user` and normal are two d

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song added a comment. @probinson Thanks for the input! That is my concern too mixing the user defined and language defined may not be a good idea and may actually cause confusion. This is exactly this RFC for. Let us try a different dwarf encoding and then we can continue to discuss.

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

ast added a comment. > The address spaces envisioned by the Linux kernel appear to be more > informational and not descriptive of hardware characteristics. From the kernel pov the `__user` and normal are two different address spaces that must be accessed via different kernel primitives. User ac

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

probinson added a comment. The DW_AT_address_class attribute is intended to be used for target architectures where a simple address value is ambiguous, and the debugger needs additional information to resolve the ambiguity. The canonical example is something like i386 with its segmented addres

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song created this revision. yonghong-song added reviewers: arsenm, aprantl, Anastasia, ast. yonghong-song added a project: debug-info. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. The RFC intends to kick off the discussion on how to support user defined addr