[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

2019-10-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG10c8dbcb840c: [clangd] Propogate context in TUScheduler::run (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69328/new/ https://review

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

2019-10-23 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: fail - 59544 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

2019-10-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 226122. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69328/new/ https://reviews.llvm.org/D69328 Files: clang-tools-ex

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

2019-10-23 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: fail - 59544 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

2019-10-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D69328#1718549 , @kadircet wrote: > In D69328#1718509 , @sammccall wrote: > > > Oops, this doesn't actually work - you're not setting the cloned context > > anywhere... > > > I am movi

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

2019-10-23 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:924 +Action = std::move(Action)]() mutable { Action(); }; + PreambleTasks->runAsync(Name, std::move(ActionWithCtx)); } Maybe inline `ActionWithCtx`

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

2019-10-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall requested changes to this revision. sammccall added a comment. This revision now requires changes to proceed. Oops, this doesn't actually work - you're not setting the cloned context anywhere... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

2019-10-23 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: fail - 59544 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

2019-10-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Can you modify `TEST_F(TUSchedulerTests, Run)` to verify? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69328/new/ https://reviews.llvm.o

[PATCH] D69328: [clangd] Propogate context in TUScheduler::run

2019-10-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69328 Files: clang-too