This revision was automatically updated to reflect the committed changes.
Closed by commit rGbe1a9b3863b6: [Wdocumentation] Implement \anchor (authored
by Mordante).
Changed prior to commit:
https://reviews.llvm.org/D69223?vs=231766&id=235016#toc
Repository:
rG LLVM Github Monorepo
CHANGES
gribozavr2 added a comment.
LGTM, feel free to push.
Comment at: clang/lib/AST/TextNodeDumper.cpp:493
+ case comments::InlineCommandComment::RenderAnchor:
+OS << " RenderAnchor";
+break;
Mordante wrote:
> Mordante wrote:
> > gribozavr2 wrote:
> > > Ple
Mordante marked an inline comment as done.
Mordante added inline comments.
Comment at: clang/lib/AST/TextNodeDumper.cpp:493
+ case comments::InlineCommandComment::RenderAnchor:
+OS << " RenderAnchor";
+break;
Mordante wrote:
> gribozavr2 wrote:
> > Pleas
Mordante marked an inline comment as done.
Mordante added a comment.
Thanks for the review! I recently acquired commit access so I'll commit it
after updating the unit test.
Comment at: clang/lib/AST/TextNodeDumper.cpp:493
+ case comments::InlineCommandComment::RenderAnchor:
gribozavr2 accepted this revision.
gribozavr2 added a comment.
This revision is now accepted and ready to land.
With that last comment, LGTM. Do you have commit access?
Comment at: clang/lib/AST/TextNodeDumper.cpp:493
+ case comments::InlineCommandComment::RenderAnchor:
+O
Mordante updated this revision to Diff 231766.
Mordante marked 2 inline comments as done.
Mordante added a comment.
Addresses review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69223/new/
https://reviews.llvm.org/D69223
Files:
clang/bindings/xml/comment-xml-schema.rng
c
gribozavr2 marked an inline comment as done.
gribozavr2 added inline comments.
Comment at: clang/test/Index/comment-xml-schema.c:38
+// RUN: xmllint --noout --relaxng %S/../../bindings/xml/comment-xml-schema.rng
%S/Inputs/CommentXML/valid-inline-command-01.xml
// RUN: not xml
Mordante marked 6 inline comments as done.
Mordante added inline comments.
Comment at: clang/lib/Index/CommentToXML.cpp:650
+assert(C->getNumArgs() == 1);
+Result << "";
+appendToResultWithXMLEscaping(Arg0);
gribozavr2 wrote:
> Sholudn't this code be
gribozavr2 added a comment.
A few more comments, but generally looks good!
Comment at: clang/include/clang-c/Documentation.h:188
+ /**
+ * Command argument should not be rendered (since it is a only defines
+ * an anchor).
"since it is a only" => "since it
Mordante updated this revision to Diff 231592.
Mordante added a comment.
Addresses review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69223/new/
https://reviews.llvm.org/D69223
Files:
clang/bindings/xml/comment-xml-schema.rng
clang/include/clang-c/Documentation.h
clan
Mordante marked 5 inline comments as done.
Mordante added a comment.
Thanks for the review. I'll address your comments and upload a new version.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69223/new/
https://reviews.llvm.org/D69223
___
gribozavr2 added a comment.
Thank you for the contribution and sorry for the review delay!
Comment at: clang/bindings/xml/comment-xml-schema.rng:583
+
+
+
Since the name of the anchor is not a part of the document text, it should be
an at
Mordante created this revision.
Mordante added a reviewer: gribozavr.
Mordante added a project: clang.
Herald added a subscriber: arphaman.
I'm not sure it should be added to the `InlineComment` group. It's not entirely
a markup. Do you think it should be a in a separate group?
(I also have not
13 matches
Mail list logo
