[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4a7c1259e8a: [clang-format] Add SpaceBeforeBrackets (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D6920?vs=229612&id=229686#toc Repository: rG LLVM Github Monorepo

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

sylvestre.ledru added a comment. Would be nice to add this to the release notes too ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6920/new/ https://reviews.llvm.org/D6920 ___ cfe-commits mailing lis

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

sylvestre.ledru added a comment. fyi, +x permissions was added to clang/lib/Format/Format.cpp I reverted the change in a4a7c1259e8a8f2d11fa29686a6c2834948c1358 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay added a comment. In D6920#1748764 , @sylvestre.ledru wrote: > Would be nice to add this to the release notes too ;) Addressing this and other missing release notes in D70355: [clang-format] [NFC] add recent changes to release notes

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay added a comment. @Anteru thanks for the patch this got landed today, I got burnt by the 100755 mode change on the file, but thanks to @sylvestre.ledru it got resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6920/new/ https://

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

Anteru added a comment. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6920/new/ https://reviews.llvm.org/D6920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for this patch. I'm sorry it took so long, I think this is a perfectly reasonable idea and helps cover the functionality that visual studio also supports. (which ulti

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

Anteru updated this revision to Diff 229612. Anteru edited the summary of this revision. Anteru added a comment. Updated as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6920/new/ https://reviews.llvm.org/D6920 Files: clang/include/clang/Format/Format.h clang/lib/Format/

[PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

MyDeveloperDay added a comment. I realize this is an old diff, and you and I have just spoke about it on twitter https://twitter.com/NIV_Anteru/status/1193792307386081281?s=20 would you consider rebasing as the /brief style isn't used any more It would help the approval process if you could hig

Re: [PATCH] D6920: [clang-format] Add SpaceBeforeBrackets

Anteru updated this revision to Diff 35810. Anteru added a comment. Here's an updated diff which should do the trick. If not, please tell me how to improve -- this is my first change to Clang. http://reviews.llvm.org/D6920 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Fo