[PATCH] D69177: [clangd] Propogate FS into Tweak::Selection

2019-10-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet abandoned this revision. kadircet added a comment. As discussed offline, dropping the change to fetch the FS from filemanager, to prevent any consistency that might be caused due to having different contents for files in AST while creating it vs while generating refactorings. Reposito

[PATCH] D69177: [clangd] Propogate FS into Tweak::Selection

2019-10-21 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. This can be obtained from the file manager inside the AST. I guess a helper function to do this would be helpful, but I don't think we need to strore another copy of it. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D69177: [clangd] Propogate FS into Tweak::Selection

2019-10-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. kadircet added a parent revision: D69165: [clangd] Store Index in Tweak::Selection. Incoming define out-of-line co