[PATCH] D69165: [clangd] Store Index in Tweak::Selection

2019-10-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8aa84ad37db7: [clangd] Store Index in Tweak::Selection (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D69165?vs=225871&id=226399#toc Repository: rG LLVM Github Monorepo CH

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

2019-10-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 225871. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69165/new/ https://reviews.llvm.org/D69165 Files: clang-tools-ex

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

2019-10-21 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51 +Selection(ParsedAST &AST, unsigned Ra

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

2019-10-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 225850. kadircet added a comment. - Store unique_ptr instead of a raw one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69165/new/ https://reviews.llvm.org/D69165 Files: clang-tools-extra/clangd/ClangdServ

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

2019-10-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTesting.h:71 + // Index to be passed into Tweak::Selection. + const SymbolIndex *Index = nullptr; + ilya-biryukov wrote: > kadircet wr

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

2019-10-21 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTesting.h:71 + // Index to be passed into Tweak::Selection. + const SymbolIndex *Index = nullptr; + kadircet wrote: > ilya-biryukov wrote: > > How is this index populated?

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

2019-10-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTesting.h:71 + // Index to be passed into Tweak::Selection. + const SymbolIndex *Index = nullptr; + ilya-biryukov wrote: > How is this

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

2019-10-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 225837. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69165/new/ https://reviews.llvm.org/D69165 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-e

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

2019-10-21 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Overall LG, just a few quick questions. Comment at: clang-tools-extra/clangd/refactor/Tweak.h:65 SelectionTree ASTSelection; +/// The Index being used by ClangdServer. +const SymbolIndex *Index = nullptr; NIT: Let's a

[PATCH] D69165: [clangd] Store Index in Tweak::Selection

2019-10-18 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Incoming define out-of-line tweak requires access to index. This patch simply propogates the index in ClangdServer