[PATCH] D69129: [AMDGPU] Fix assertion due to initializer list

2019-10-20 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGe6125fc0ec34: [AMDGPU] Fix assertion due to initializer list (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.o

[PATCH] D69129: [AMDGPU] Fix assertion due to initializer list

2019-10-20 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:3898 +Entry = CE->stripPointerCasts(); } rjmccall wrote: > You can just make this whole thing `Entry = Entry->stripPointerCasts()`. will do w

[PATCH] D69129: [AMDGPU] Fix assertion due to initializer list

2019-10-19 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Minor change, but otherwise LGTM. Comment at: lib/CodeGen/CodeGenModule.cpp:3898 +Entry = CE->stripPointerCasts(); } You can just make this whol

[PATCH] D69129: [AMDGPU] Fix assertion due to initializer list

2019-10-17 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: rjmccall. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. Sometimes a global var is replaced by a different llvm value. clang use GetAddrOfGlobalVar to get the original llvm global variable. For most targets, GetAddrOfGlobalV