[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7a487adfedb: [clang][driver] Print compilation phases with indentation. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69124/new/ https

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Neat. I like the visual cues showing what gets passed on to the next processing stage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69124/new/ https

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao updated this revision to Diff 225620. hliao added a comment. revise the output by drawing tree lines. now, the output looks like $ clang -x cuda -ccc-print-phases --cuda-gpu-arch=sm_30 --cuda-gpu-arch=sm_60 -c dummy.cpp +- 0: input, "/home/michliao/dummy.cpp", cuda, (host-c

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. In D69124#1713427 , @tra wrote: > This is... rather oddly-structured output. My brain refuses to accept that > the most-indented phase is the input. > Perhaps we should do `llvm::errs().indent(MaxIdent-Ident)`. This should give >

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

tra added a comment. This is... rather oddly-structured output. My brain refuses to accept that the most-indented phase is the input. Perhaps we should do `llvm::errs().indent(MaxIdent-Ident)`. This should give us something like this (withMaxIdent=9), which is somewhat easier to grok, IMO:

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. In D69124#1713360 , @tra wrote: > Could you give an example of before/after output? For HIP $ clang -x hip -ccc-print-phases --cuda-gpu-arch=gfx900 --cuda-gpu-arch=gfx906 -c ~/dummy.cpp 0: input, "/home/michliao/dummy.c

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. In D69124#1713360 , @tra wrote: > Could you give an example of before/after output? $ clang -x cuda -ccc-print-phases --cuda-gpu-arch=sm_30 --cuda-gpu-arch=sm_60 -c ~/dummy.cpp 0: input, "/home/michliao/dummy.cpp", cud

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

tra added a comment. Could you give an example of before/after output? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69124/new/ https://reviews.llvm.org/D69124 ___ cfe-commits mailing list cfe-commits@

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao created this revision. hliao added reviewers: tra, sfantao, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao added a comment. this patch enables the dumping of actions in the hierarchy or tree. In most cases, it's a linear list but, for offload compilat

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. this patch enables the dumping of actions in the hierarchy or tree. In most cases, it's a linear list but, for offload compilation, a tree representation is more intuitive. Even though there are cross-subtree edges, they are rare and also noted in the corresponding action