nick updated this revision to Diff 336533.
nick edited the summary of this revision.
nick added reviewers: njames93, steveire.
nick added a comment.
Rebased. Now using native `cxxBaseSpecifier` and `hasDirectBase`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://review
njames93 added a comment.
First of all I'd definitely wait until a patch to include ASTMatcher support
for CXXBaseSpecifier lands before progressing with this.
Secondly this issue should be warned on by clang when compiling with c++17 with
some stdlib support, libc++ should mark iterator as dep
nick marked 2 inline comments as done.
nick added inline comments.
Comment at:
clang-tools-extra/clang-tidy/modernize/DeprecatedIteratorBaseCheck.cpp:218
+ // Requires C++.
+ if (!getLangOpts().CPlusPlus)
+return;
Eugene.Zelenko wrote:
> Should it check fo
nick updated this revision to Diff 225133.
nick added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69000/new/
https://reviews.llvm.org/D69000
Files:
clang-tools-extra/clang-tidy/modernize/CMakeLists.txt
clang-to
Eugene.Zelenko added inline comments.
Comment at:
clang-tools-extra/clang-tidy/modernize/DeprecatedIteratorBaseCheck.cpp:93
+// TODO: Is there a way to get the location without lexer gymnastics?
+auto Colon = findPreviousTokenKind(R.getBegin(), SM, LangOpts, tok::colon);
nick created this revision.
nick added a reviewer: alexfh.
nick added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, kristof.beyls, xazax.hun, mgorny.
Herald added a project: clang.
Finds deprecated in C++17 inheritance from `std::iterator` and replaces it with
type aliases.
