ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:135
+ // Since initialization of CDBs and ClangdServer is done lazily, the
following
+ // context captures the one used while creating ClangdLSPServer and passes it
N
merge_guards_bot added a comment.
Bulid results are available at
http://results.llvm-merge-guard.org/Phabricator-39
See http://jenkins.llvm-merge-guard.org/job/Phabricator/39/ for more details.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68978
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9d66247e9b78: [clangd] Propagate main context into
ClangdServer (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68978/new/
https://rev
kadircet updated this revision to Diff 225027.
kadircet marked an inline comment as done.
kadircet added a comment.
- Move context swapping next to server creation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68978/new/
https://reviews.llvm.org/D6
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Otherwise LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68978/new/
https://reviews.llvm.org/D68978
_
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:463
+ // Server, CDB, etc.
+ llvm::Optional MainContext;
+ MainContext.emplace(BackgroundContext.clone());
As discussed offline: I think it'd be clearer to put this in a
merge_guards_bot added a comment.
Bulid results are available at
http://results.llvm-merge-guard.org/Phabricator-35
See http://jenkins.llvm-merge-guard.org/job/Phabricator/35/ for more details.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68978
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Currently clangd initializes the ClangdServer lazily during
onInitialize request, and it results in pro
